Make parameters panel max height shorter for smaller screens #988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src/' <!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Reduce `ScrollAreaViewport` max height in `WorkflowParametersPanel.tsx` for improved small screen display. > > - **UI Adjustment**: > - In `WorkflowParametersPanel.tsx`, change `ScrollAreaViewport` max height from `600px` to `max-h-96` (384px) for better display on smaller screens. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for 09a1216bad70de9b0b4b2bd7b79ebecdc8f59869. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on ebb8ca0 in 8 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/panels/WorkflowParametersPanel.tsx:110
- Draft comment:
The change frommax-h-[600px]tomax-h-96is consistent with the PR description and should improve display on smaller screens. - Reason this comment was not posted:
Confidence changes required:0%
The change from 600px to max-h-96 (384px) is consistent with the PR description and should improve display on smaller screens.
Workflow ID: wflow_xHxJokdSgEZc5U8N
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to ebb8ca0 in 11 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/panels/WorkflowParametersPanel.tsx:110
- Draft comment:
The change frommax-h-[600px]tomax-h-96is consistent with the PR description and should improve display on smaller screens. Ensure this change does not negatively impact usability on larger screens. - Reason this comment was not posted:
Confidence changes required:20%
The change frommax-h-[600px]tomax-h-96is consistent with the PR description and should improve display on smaller screens.
Workflow ID: wflow_Uobo6jHbPcyY9p4U
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Reduce
ScrollAreaViewportmax height inWorkflowParametersPanel.tsxfor improved small screen display.WorkflowParametersPanel.tsx, reduceScrollAreaViewportmax height from600pxtomax-h-96(384px) for better small screen display.This description was created by
for ebb8ca0. It will automatically update as commits are pushed.